Repository navigation
refactor(test-kit): drop the daemon-contracts dependency - #3686
Merged
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
thymikee
force-pushed
the
refactor/test-kit-drop-daemon-contracts
branch
from
October 15, 2026 17:59
6c69048 to
3c7e428
Compare
Contributor
|
Contributor
Size Report
Startup median (7 runs, lower is better):
|
…nsumer Pure git mv, named for the one test that uses it; the entry, importer and manifest follow in the next commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
spawnLegacyDaemonFixture was test-kit's only use of daemon-contracts, which now leaves the packages test-kit builds on free to declare test-kit as a devDependency. The fixture's repo-root URLs follow it one directory up. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
thymikee
added this pull request to stack #3692
October 15, 2026 18:40
thymikee
force-pushed
the
refactor/test-kit-drop-daemon-contracts
branch
from
October 15, 2026 18:57
3c7e428 to
25e3183
Compare
Member
Author
|
I found nothing to change at 25e3183. The PR drops the daemon-contracts dependency from test-kit as described, and the code looks right. CI is green, with 23 checks and none failing. There are no conflicts, and nothing else stands between this and merge. I did not run the tests or the typecheck myself. I also did not check whether the legacy daemon path the fixture models is slated for deletion. The test still exercises that path, so the fixture is not dead code. |
thymikee
added
the
ready-for-human
thymikee
added a commit
that referenced
this pull request
Oct 16, 2026
…ctions-1 * origin/main: feat(react-devtools): inspect React components and profile renders through the Metro inspector (#3613) refactor(daemon-contracts): drop the registration and claims fixture exports (#3689) refactor(test-kit): drop the daemon-contracts dependency (#3686) refactor(test-kit): drop command-registry by making the replay-script generator a root fixture (#3687) fix(ios): handle delayed launch confirmations without stopping XCTest (#3682) refactor(test-kit): move the dispatch-disclosure harness out of contracts (#3690) refactor(test-kit): host the target classification capture fixture (#3691) ci: fold six CI jobs into four with parallel and background steps; cancel superseded and closed-PR runs (#3658) build(typescript): move root project references into tsconfig.typecheck.json (#3688) chore(daemon): declare @agent-device/proxy as a devDependency, since only a test imports it (#3685) refactor(settings): declare settings once and admit them per setting (#3662) # Conflicts: # packages/platform-android/src/alert.ts # website/docs/docs/limrun.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
spawnLegacyDaemonFixturewas test-kit's only use of@agent-device/daemon-contracts, and rootsrc/__tests__/daemon-registration-owner.test.tswas its only importer. It moves beside that test, and test-kit drops thedaemon-contractsdependency and tsconfig reference. daemon-contracts (and any package that depended on it) is then free to declare test-kit as a devDependency without a project-reference cycle.Graph check (workspace
dependencies+devDependencies, transitive)Packages that can never declare test-kit (they sit under it): capture-kit, command-registry, contracts, host-kit, kernel, ad-script, selectors. daemon-contracts leaves that set. Nothing in test-kit's
srcimported daemon-contracts besides this fixture (git grepclean after the move).Commits
git mv packages/test-kit/src/legacy-daemon-fixture.ts src/__tests__/daemon-registration-owner.fixtures.ts— 100% similarity, named for the one test that uses it.new URL(…)hops lose one../for the shallower directory (the test exercises both, 47/0).Parity
src/__tests__/daemon-registration-owner.test.ts: 47 passed / 0 failed onorigin/main, 47 / 0 on this head. It stays undersrc/**/*.test.ts(unit-core). Novi.mockin the moved file. test-kit exports: still the single.entry; named exports 67 → 66 (spawnLegacyDaemonFixtureremoved).Gates
check:layering,check:gate-manifest,check:fallow,pnpm format: clean.check:quick/check:affected --runfail on main's own typecheck errors (fixed by #3684); with #3684's commits cherry-picked locally on a throwaway branch,check:affected --runpasses (1828 files, 15474 tests). Rebase after #3684 merges.🤖 Generated with Claude Code