Repository navigation
Conversation
chromedp gives Chrome 20s to print its DevTools address, and wasmbrowsertest has no option to raise that limit. On 20 fresh GitHub runners the first Chrome start took 5.2s to 27.4s, so TestWasm sometimes failed with "websocket url timeout reached" before any wasm test ran. Later starts on the same runners took at most 1.2s, so one retry is enough in practice.
mafredri
marked this pull request as ready for review
October 26, 2026 14:27
mafredri
enabled auto-merge (squash)
October 26, 2026 14:30
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestWasm fails with
websocket url timeout reachedwhen Chrome takes more than 20s to print its DevTools address. chromedp sets that limit, and wasmbrowsertest has no option to raise it. TestWasm now retries on that error, up to 3 attempts. Any other failure still fails at once.The slow start is Chrome's first start on a fresh runner, not CPU load. On 20 runners the first start took 5.2s to 27.4s, and 3 took over 20s. 416 later starts, 373 of them during
go test --race --bench=. ./..., took at most 1.2s.Failed runs: 38919884888, 40027879058, 40084933854.
Verification
ci/lint.shpassed.