Skip to content

test: retry TestWasm when Chrome does not start in time #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mafredri wants to merge 3 commits into
base: master
Choose a base branch
from
Open

test: retry TestWasm when Chrome does not start in time #584

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69e2555
test: retry TestWasm when Chrome does not start in time
mafredri Oct 26, 2026
4788aa0
test: bound the TestWasm retry loop in its header
mafredri Oct 26, 2026
895dff9
test: shorten the TestWasm retry comment
mafredri Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions conn_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,15 +459,25 @@ func TestWasm(t *testing.T) {
}))
defer s.Close()

ctx, cancel := context.WithTimeout(context.Background(), time.Minute)
ctx, cancel := context.WithTimeout(context.Background(), 3*time.Minute)
defer cancel()

cmd := exec.CommandContext(ctx, "go", "test", "-exec=wasmbrowsertest", ".", "-v")
cmd.Env = append(cleanEnv(os.Environ()), "GOOS=js", "GOARCH=wasm", fmt.Sprintf("WS_ECHO_SERVER_URL=%v", s.URL))

b, err := cmd.CombinedOutput()
if err != nil {
t.Fatalf("wasm test binary failed: %v:\n%s", err, b)
// Chrome's first start on a fresh CI runner can exceed the 20s that
// wasmbrowsertest allows. No wasm test has run by then, so retrying is safe.
const chromeStartTimeout = "websocket url timeout reached"
const attempts = 3
for attempt := 1; attempt <= attempts; attempt++ {
cmd := exec.CommandContext(ctx, "go", "test", "-exec=wasmbrowsertest", ".", "-v")
cmd.Env = append(cleanEnv(os.Environ()), "GOOS=js", "GOARCH=wasm", fmt.Sprintf("WS_ECHO_SERVER_URL=%v", s.URL))

b, err := cmd.CombinedOutput()
if err == nil {
return
}
if attempt == attempts || ctx.Err() != nil || !bytes.Contains(b, []byte(chromeStartTimeout)) {
t.Fatalf("wasm test binary failed: %v:\n%s", err, b)
}
t.Logf("attempt %d/%d: Chrome did not start in time, retrying", attempt, attempts)
}
}

Expand Down
Loading