Repository navigation
Drop a PHPStan ignore that 2.3.0 no longer needs - #10
Merged
Merged
Conversation
Core's trunk moved to PHPStan 2.3.0, which no longer reports method.impossibleType on the assertion in the memzero test. The tests are analyzed inside wordpress-develop, where an unmatched ignore is an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeps the shared tests identical to the core patch (WordPress/wordpress-develop#13759) after it merged trunk, which moved to PHPStan 2.3.0. One comment in one test; no behavior change. Can ride along with the next round of feedback.