Skip to content

Drop a PHPStan ignore that 2.3.0 no longer needs #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericmann merged 1 commit into from
Oct 9, 2026
Merged

Drop a PHPStan ignore that 2.3.0 no longer needs #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/phpunit/test-wp-secrets-memzero.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public function test_leaves_non_string_values_untouched(): void {

wp_secrets_memzero( $value ); // @phpstan-ignore argument.type (Intentionally passing a non-string value.)

$this->assertSame( 42, $value ); // @phpstan-ignore method.impossibleType (The by-reference parameter is documented as a string; this checks a non-string comes back untouched.)
$this->assertSame( 42, $value );
}

public function test_leaves_an_empty_string_untouched(): void {
Expand Down
Loading