Skip to content

fix: keep StreamingReporter#log_error private - #3150

Open
sean0407 wants to merge 1 commit into
getsentry:masterfrom
sean0407:codex/sentry-ruby-3146-private-log-error
Open

sean0407 wants to merge 1 commit into
getsentry:masterfrom
sean0407:codex/sentry-ruby-3146-private-log-error

Conversation

@sean0407

Copy link
Copy Markdown

Resolves #3146.

StreamingReporter is prepended to ActionController::Live, but its log_error override was public. That changes the public method set of controllers including ActionController::Live and exposes log_error as an action.

This marks the override private and adds a regression spec that prepends it over a private log_error, then checks the resulting controller method remains private.

Checks performed:

  • Ruby syntax checks for both changed files: passed.
  • Focused RSpec example in an isolated Ruby 3.4 harness with a minimal spec_helper stub: 1 example, 0 failures.
  • Direct Ruby prepend visibility probe: passed.
  • git diff --check: passed.

Co-Authored-By: Codex <noreply@openai.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-21T15:01:44.307572Z 6a1117b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StreamingReporter#log_error visibility changed to :public

1 participant