Skip to content

fix: keep StreamingReporter#log_error private #3150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sean0407 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: keep StreamingReporter#log_error private #3150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sentry-rails/lib/sentry/rails/overrides/streaming_reporter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ module Sentry
module Rails
module Overrides
module StreamingReporter
private

def log_error(exception)
Sentry::Rails.capture_exception(exception)
super
Expand Down
20 changes: 20 additions & 0 deletions sentry-rails/spec/sentry/rails/overrides/streaming_reporter_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# frozen_string_literal: true

require 'spec_helper'
require 'sentry/rails/overrides/streaming_reporter'

RSpec.describe Sentry::Rails::Overrides::StreamingReporter do
it "keeps ActionController::Live's private method private when prepended" do
live_module = Module.new do
private

def log_error(_exception)
end
end
live_module.prepend(described_class)
controller_class = Class.new { include live_module }

expect(controller_class.public_method_defined?(:log_error)).to be(false)
expect(controller_class.private_method_defined?(:log_error)).to be(true)
end
end