Repository navigation
Conversation
Contributor
Click to show differences in coveragegoGenerated file changes for go
- `Standard library <https://pkg.go.dev/std>`_,"````, ``archive/*``, ``bufio``, ``bytes``, ``cmp``, ``compress/*``, ``container/*``, ``context``, ``crypto``, ``crypto/*``, ``database/*``, ``debug/*``, ``embed``, ``encoding``, ``encoding/*``, ``errors``, ``expvar``, ``flag``, ``fmt``, ``go/*``, ``hash``, ``hash/*``, ``html``, ``html/*``, ``image``, ``image/*``, ``index/*``, ``io``, ``io/*``, ``log``, ``log/*``, ``maps``, ``math``, ``math/*``, ``mime``, ``mime/*``, ``net``, ``net/*``, ``os``, ``os/*``, ``path``, ``path/*``, ``plugin``, ``reflect``, ``reflect/*``, ``regexp``, ``regexp/*``, ``slices``, ``sort``, ``strconv``, ``strings``, ``sync``, ``sync/*``, ``syscall``, ``syscall/*``, ``testing``, ``testing/*``, ``text/*``, ``time``, ``time/*``, ``unicode``, ``unicode/*``, ``unsafe``, ``weak``",52,674,127
+ `Standard library <https://pkg.go.dev/std>`_,"````, ``archive/*``, ``bufio``, ``bytes``, ``cmp``, ``compress/*``, ``container/*``, ``context``, ``crypto``, ``crypto/*``, ``database/*``, ``debug/*``, ``embed``, ``encoding``, ``encoding/*``, ``errors``, ``expvar``, ``flag``, ``fmt``, ``go/*``, ``hash``, ``hash/*``, ``html``, ``html/*``, ``image``, ``image/*``, ``index/*``, ``io``, ``io/*``, ``log``, ``log/*``, ``maps``, ``math``, ``math/*``, ``mime``, ``mime/*``, ``net``, ``net/*``, ``os``, ``os/*``, ``path``, ``path/*``, ``plugin``, ``reflect``, ``reflect/*``, ``regexp``, ``regexp/*``, ``slices``, ``sort``, ``strconv``, ``strings``, ``sync``, ``sync/*``, ``syscall``, ``syscall/*``, ``testing``, ``testing/*``, ``text/*``, ``time``, ``time/*``, ``unicode``, ``unicode/*``, ``unsafe``, ``weak``",52,696,127
- Totals,,690,1134,1580
+ Totals,,690,1156,1580
- context,,,5,,,,,,,,,,,,,,,,,,,,,,,5,
+ context,,,10,,,,,,,,,,,,,,,,,,,,,,,10,
- crypto,,,10,,,,,,,,,,,,,,,,,,,,,,,10,
+ crypto,,,24,,,,,,,,,,,,,,,,,,,,,,,24,
- io,5,4,34,,,,,,5,,,,,,,,,,,,,,4,,,34,
+ io,5,4,36,,,,,,5,,,,,,,,,,,,,,4,,,36,
- math/big,,,1,,,,,,,,,,,,,,,,,,,,,,,1,
+ math/big,,,2,,,,,,,,,,,,,,,,,,,,,,,2, |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The TLS summaries currently introduce false-positive flows from unused ConnectionState arguments.
4 open findings
What changed in this PR
Adds Go 1.21 standard-library data-flow models and corresponding regression coverage.
Changes:
- Models new
context,crypto/tls,io/fs, andmath/bigAPIs. - Adds taint-flow fixtures and a change note.
| File | Description |
|---|---|
go/ql/lib/ext/context.model.yml |
Models new context APIs. |
go/ql/lib/ext/crypto.tls.model.yml |
Models TLS session and QUIC APIs. |
go/ql/lib/ext/io.fs.model.yml |
Models filesystem formatting functions. |
go/ql/lib/ext/math.big.model.yml |
Models Int.Float64. |
go/ql/test/library-tests/semmle/go/frameworks/StdlibTaintFlow/Context.go |
Tests context summaries. |
go/ql/test/library-tests/semmle/go/frameworks/StdlibTaintFlow/CryptoTls.go |
Tests TLS summaries. |
go/ql/test/library-tests/semmle/go/frameworks/StdlibTaintFlow/IoFs.go |
Tests filesystem summaries. |
go/ql/test/library-tests/semmle/go/frameworks/StdlibTaintFlow/MathBig.go |
Tests Int.Float64. |
go/ql/src/change-notes/2026-09-30-model-go1.21-minor-library-changes.md |
Documents the analysis improvement. |
Files not reviewed (2)
- go/ql/test/library-tests/semmle/go/frameworks/StdlibTaintFlow/Context.go: Generated file
- go/ql/test/library-tests/semmle/go/frameworks/StdlibTaintFlow/CryptoTls.go: Generated file
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - ["crypto/tls", "", False, "Server", "", "", "Argument[0]", "ReturnValue", "taint", "manual"] | ||
| - ["crypto/tls", "ClientSessionState", True, "ResumptionState", "", "", "Argument[receiver]", "ReturnValue[0..1]", "taint", "manual"] | ||
| - ["crypto/tls", "Config", True, "DecryptTicket", "", "", "Argument[receiver]", "ReturnValue[0]", "taint", "manual"] | ||
| - ["crypto/tls", "Config", True, "DecryptTicket", "", "", "Argument[0..1]", "ReturnValue[0]", "taint", "manual"] |
Comment on lines
+13
to
+17
| - ["crypto/tls", "ClientSessionState", True, "ResumptionState", "", "", "Argument[receiver]", "ReturnValue[0..1]", "taint", "manual"] | ||
| - ["crypto/tls", "Config", True, "DecryptTicket", "", "", "Argument[receiver]", "ReturnValue[0]", "taint", "manual"] | ||
| - ["crypto/tls", "Config", True, "DecryptTicket", "", "", "Argument[0..1]", "ReturnValue[0]", "taint", "manual"] | ||
| - ["crypto/tls", "Config", True, "EncryptTicket", "", "", "Argument[receiver]", "ReturnValue[0]", "taint", "manual"] | ||
| - ["crypto/tls", "Config", True, "EncryptTicket", "", "", "Argument[0..1]", "ReturnValue[0]", "taint", "manual"] |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add models for the minor library changes from Go 1.21.