Skip to content

Go: Add models for go 1.21 #22797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
owen-mc wants to merge 1 commit into
base: main
Choose a base branch
from
+235 −0
Open

Go: Add models for go 1.21 #22797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions go/ql/lib/ext/context.model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,14 @@ extensions:
pack: codeql/go-all
extensible: summaryModel
data:
# AfterFunc should be modeled when callback-based library models are supported.
- ["context", "", False, "WithCancel", "", "", "Argument[0]", "ReturnValue[0]", "taint", "manual"]
- ["context", "", False, "WithDeadline", "", "", "Argument[0]", "ReturnValue[0]", "taint", "manual"]
- ["context", "", False, "WithDeadlineCause", "", "", "Argument[0]", "ReturnValue[0]", "taint", "manual"]
- ["context", "", False, "WithDeadlineCause", "", "", "Argument[2]", "ReturnValue[0]", "taint", "manual"]
- ["context", "", False, "WithTimeout", "", "", "Argument[0]", "ReturnValue[0]", "taint", "manual"]
- ["context", "", False, "WithTimeoutCause", "", "", "Argument[0]", "ReturnValue[0]", "taint", "manual"]
- ["context", "", False, "WithTimeoutCause", "", "", "Argument[2]", "ReturnValue[0]", "taint", "manual"]
- ["context", "", False, "WithValue", "", "", "Argument[0..2]", "ReturnValue", "taint", "manual"]
- ["context", "", False, "WithoutCancel", "", "", "Argument[0]", "ReturnValue", "taint", "manual"]
- ["context", "Context", True, "Value", "", "", "Argument[receiver]", "ReturnValue", "taint", "manual"]
14 changes: 14 additions & 0 deletions go/ql/lib/ext/crypto.tls.model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,19 @@ extensions:
extensible: summaryModel
data:
- ["crypto/tls", "", False, "Client", "", "", "Argument[0]", "ReturnValue", "taint", "manual"]
- ["crypto/tls", "", False, "NewResumptionState", "", "", "Argument[0..1]", "ReturnValue[0]", "taint", "manual"]
- ["crypto/tls", "", False, "NewListener", "", "", "Argument[0]", "ReturnValue", "taint", "manual"]
- ["crypto/tls", "", False, "ParseSessionState", "", "", "Argument[0]", "ReturnValue[0]", "taint", "manual"]
- ["crypto/tls", "", False, "QUICClient", "", "", "Argument[0]", "ReturnValue", "taint", "manual"]
- ["crypto/tls", "", False, "QUICServer", "", "", "Argument[0]", "ReturnValue", "taint", "manual"]
- ["crypto/tls", "", False, "Server", "", "", "Argument[0]", "ReturnValue", "taint", "manual"]
- ["crypto/tls", "ClientSessionState", True, "ResumptionState", "", "", "Argument[receiver]", "ReturnValue[0..1]", "taint", "manual"]
- ["crypto/tls", "Config", True, "DecryptTicket", "", "", "Argument[receiver]", "ReturnValue[0]", "taint", "manual"]
- ["crypto/tls", "Config", True, "DecryptTicket", "", "", "Argument[0..1]", "ReturnValue[0]", "taint", "manual"]
- ["crypto/tls", "Config", True, "EncryptTicket", "", "", "Argument[receiver]", "ReturnValue[0]", "taint", "manual"]
- ["crypto/tls", "Config", True, "EncryptTicket", "", "", "Argument[0..1]", "ReturnValue[0]", "taint", "manual"]
Comment on lines +13 to +17
- ["crypto/tls", "QUICConn", True, "ConnectionState", "", "", "Argument[receiver]", "ReturnValue", "taint", "manual"]
- ["crypto/tls", "QUICConn", True, "HandleData", "", "", "Argument[1]", "Argument[receiver]", "taint", "manual"]
- ["crypto/tls", "QUICConn", True, "NextEvent", "", "", "Argument[receiver]", "ReturnValue", "taint", "manual"]
- ["crypto/tls", "QUICConn", True, "SetTransportParameters", "", "", "Argument[0]", "Argument[receiver]", "taint", "manual"]
- ["crypto/tls", "SessionState", True, "Bytes", "", "", "Argument[receiver]", "ReturnValue[0]", "taint", "manual"]
2 changes: 2 additions & 0 deletions go/ql/lib/ext/io.fs.model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ extensions:
extensible: summaryModel
data:
- ["io/fs", "", False, "FileInfoToDirEntry", "", "", "Argument[0]", "ReturnValue", "taint", "manual"]
- ["io/fs", "", False, "FormatDirEntry", "", "", "Argument[0]", "ReturnValue", "taint", "manual"]
- ["io/fs", "", False, "FormatFileInfo", "", "", "Argument[0]", "ReturnValue", "taint", "manual"]
- ["io/fs", "", False, "Glob", "", "", "Argument[0]", "ReturnValue[0]", "taint", "manual"]
- ["io/fs", "", False, "ReadDir", "", "", "Argument[0]", "ReturnValue[0]", "taint", "manual"]
- ["io/fs", "", False, "ReadFile", "", "", "Argument[0]", "ReturnValue[0]", "taint", "manual"]
Expand Down
1 change: 1 addition & 0 deletions go/ql/lib/ext/math.big.model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ extensions:
pack: codeql/go-all
extensible: summaryModel
data:
- ["math/big", "Int", True, "Float64", "", "", "Argument[receiver]", "ReturnValue[0]", "taint", "manual"]
- ["math/big", "Int", True, "Int64", "", "", "Argument[receiver]", "ReturnValue[0]", "taint", "manual"]
4 changes: 4 additions & 0 deletions go/ql/src/change-notes/2026-09-30-model-go1.21-minor-library-changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* Added data flow models for APIs mentioned in the minor library changes section of the Go 1.21 release notes.
54 changes: 54 additions & 0 deletions go/ql/test/library-tests/semmle/go/frameworks/StdlibTaintFlow/Context.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

130 changes: 130 additions & 0 deletions go/ql/test/library-tests/semmle/go/frameworks/StdlibTaintFlow/CryptoTls.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions go/ql/test/library-tests/semmle/go/frameworks/StdlibTaintFlow/IoFs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,16 @@ func walkDirCallback(path string, d fs.DirEntry, _ error) error {
}

func steps() {
{
source := newSource(17).(fs.DirEntry)
out := fs.FormatDirEntry(source)
sink(17, out)
}
{
source := newSource(18).(fs.FileInfo)
out := fs.FormatFileInfo(source)
sink(18, out)
}
{
source := newSource(16).(fs.FileInfo)
out := fs.FileInfoToDirEntry(source)
Expand Down
14 changes: 14 additions & 0 deletions go/ql/test/library-tests/semmle/go/frameworks/StdlibTaintFlow/MathBig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package main

import "math/big"

func TaintStepTest_MathBigIntFloat64(sourceCQL interface{}) interface{} {
out, _ := sourceCQL.(*big.Int).Float64()
return out
}

func RunAllTaints_MathBig() {
source := newSource(0)
out := TaintStepTest_MathBigIntFloat64(source)
sink(0, out)
}
Loading