Repository navigation
Tell the Planner about hosted images - #442
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Planner's system prompt still said "Images are referenced by absolute
https:URL." Since #441, an image can also use the/images/<sha256>.<ext>path Chopin returns when it is uploaded to the document, so the Planner should accept those. It also needs to be told that only Chopin can produce such a path.What changes
apps/server/src/agent/planner.ts: images use an absolutehttps:URL or a/images/<sha256>.<ext>path that Chopin returned when the image was uploaded to this document. The Planner must never invent or guess such a path.apps/server/src/agent/planner.test.ts: a new test, "allows only Chopin-returned hosted image paths".packages/dialect/src/nodes/content.ts: theImageNodecomment describes both forms.Verification
bun test apps/server/src/agent: 168 passed, 0 failed.bun --filter '@chopin/server' types: exit 0.bunx dprint checkandbunx oxlinton the changed files: no findings.Assistant-model: Claude Opus 5.5 (fast)
Assistant-workflow: inline (implemented by a worker subagent on anthropic-api/claude-opus-5-5-fast)
Assistant-duration: 6m converged, estimated 10m
Assistant-verification: bun test passed: apps/server/src/agent (168 pass, 0 fail)
Assistant-verification: types passed: bun --filter '@chopin/server' types
Assistant-verification: dprint and oxlint passed: no findings on changed files
User-preference: Use fast subagents for everything