Skip to content

test(gax): disable jitter in CancellationTest SLOW_RETRY_SETTINGS - #14702

Merged
lqiu96 merged 1 commit into
mainfrom
fix/gax-cancellation-test-14539
Oct 20, 2026
Merged

lqiu96 merged 1 commit into
mainfrom
fix/gax-cancellation-test-14539

Conversation

@lqiu96

@lqiu96 lqiu96 commented Oct 20, 2026

Copy link
Copy Markdown
Member

Fixes #14539

@lqiu96
lqiu96 requested a review from jinseopkim0 October 20, 2026 16:55

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates CancellationTest.java by disabling jitter and increasing the total timeout duration to 10,000ms in SLOW_RETRY_SETTINGS. It also adds detailed comments explaining the retry behavior and the cancellation mechanics during retry delays to prevent test flakiness. There are no review comments, so no additional feedback is provided.

@sonarqubecloud

Copy link
Copy Markdown

@sonarqubecloud

Copy link
Copy Markdown

@lqiu96
lqiu96 marked this pull request as ready for review October 20, 2026 17:38
@lqiu96
lqiu96 requested a review from a team as a code owner October 20, 2026 17:38
@lqiu96 lqiu96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 20, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 20, 2026
@lqiu96
lqiu96 enabled auto-merge (squash) October 20, 2026 17:50
@lqiu96
lqiu96 merged commit efeaff9 into main Oct 20, 2026
377 of 390 checks passed
@lqiu96
lqiu96 deleted the fix/gax-cancellation-test-14539 branch October 20, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nightly-java8 build on macos-15-intel failed.

3 participants