Skip to content

test(gax): disable jitter in CancellationTest SLOW_RETRY_SETTINGS #14702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lqiu96 merged 1 commit into from
Oct 20, 2026
Merged

test(gax): disable jitter in CancellationTest SLOW_RETRY_SETTINGS #14702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion sdk-platform-java/gax-java/gax/src/test/java/com/google/api/gax/rpc/CancellationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,13 @@ class CancellationTest {
.setTotalTimeoutDuration(java.time.Duration.ofMillis(20L))
.build();

// Disable jitter so ExponentialRetryAlgorithm.createNextAttempt always schedules the full
// 3000ms retry delay instead of picking a random delay in [0, 3000) ms via
// ThreadLocalRandom.current().nextLong(bound), which can otherwise expire before the
// cancellation thread calls resultFuture.cancel(true).
// totalTimeoutDuration must exceed initialRetryDelayDuration (10000ms > 3000ms) because
// ExponentialRetryAlgorithm.shouldRetry checks (totalTimeout - timeElapsed - retryDelay) > 0
// before scheduling the next attempt.
private static final RetrySettings SLOW_RETRY_SETTINGS =
RetrySettings.newBuilder()
.setInitialRetryDelayDuration(java.time.Duration.ofMillis(3000L))
Expand All @@ -77,7 +84,8 @@ class CancellationTest {
.setInitialRpcTimeoutDuration(java.time.Duration.ofMillis(3000L))
.setRpcTimeoutMultiplier(1)
.setMaxRpcTimeoutDuration(java.time.Duration.ofMillis(3000L))
.setTotalTimeoutDuration(java.time.Duration.ofMillis(3000L))
.setTotalTimeoutDuration(java.time.Duration.ofMillis(10000L))
.setJittered(false)
.build();

private FakeApiClock fakeClock;
Expand Down Expand Up @@ -197,6 +205,10 @@ void cancellationDuringRetryDelay() throws Exception {
Throwable throwable =
new UnavailableException(null, FakeStatusCode.of(StatusCode.Code.UNAVAILABLE), true);
CancellationTrackingFuture<Integer> innerFuture = CancellationTrackingFuture.create();
// Attempt 1 fails immediately with UNAVAILABLE, causing CallbackChainRetryingFuture to
// schedule Attempt 2 on the executor with SLOW_RETRY_SETTINGS's retry delay.
// innerFuture is queued in Mockito for Attempt 2 and is only returned if the retry delay
// expires and AttemptCallable.call() invokes callInt.futureCall() a second time.
Mockito.when(callInt.futureCall((Integer) Mockito.any(), (ApiCallContext) Mockito.any()))
.thenReturn(RetryingTest.<Integer>immediateFailedFuture(throwable))
.thenReturn(innerFuture);
Expand All @@ -220,6 +232,12 @@ void cancellationDuringRetryDelay() throws Exception {
Truth.assertThat(gotException).isNotNull();
Truth.assertThat(resultFuture.isDone()).isTrue();
Truth.assertThat(resultFuture.isCancelled()).isTrue();
// CallbackChainRetryingFuture replaces its active attemptFuture at each step of the retry
// loop (Attempt 1 future -> scheduled retry-delay timer future -> Attempt 2 future via
// AttemptCallable.call()). While waiting in the retry delay, attemptFuture points to the
// scheduled timer future from ScheduledRetryingExecutor.submit(). Cancelling resultFuture
// during this delay cancels that timer task before AttemptCallable.call() runs Attempt 2,
// so callInt.futureCall() is never called a second time and innerFuture is never cancelled.
Truth.assertThat(innerFuture.isCancelled()).isFalse();

scheduler.shutdownNow();
Expand Down
Loading