Repository navigation
Release workflow: only run deploy in release:perform - #206
Merged
Merged
Conversation
maven-release-plugin defaults release:perform to 'deploy site-deploy' because the pom has a distributionManagement/site element. The site-deploy runs in the release checkout without git credentials and fails with "could not read Username", marking every release run as failed after the artifacts were already published. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ccutrer
requested changes
Oct 18, 2026
| git config --global user.email "41898282+github-actions[bot]@users.noreply.github.com" | ||
| - name: Maven release | ||
| run: mvn release:prepare release:perform -B -DreleaseVersion=${{ github.event.inputs.releaseVersion }} | ||
| # Only deploy; the site is published by the deploy workflow on pushes to master. |
Member
There was a problem hiding this comment.
Can you remove this comment? While Claude can be great, it sometimes is overly verbose, and it doesn't add any value here.
Contributor
Author
There was a problem hiding this comment.
Hey Cody,
long time. decide to remove some dust from some old projects for which i had no time. hopefully with claude i can at least keep them up to date.
thank you for the review.
Contributor
Author
There was a problem hiding this comment.
and i didnt want bother you with minor changes and minor project, so, i have merged them.
Member
There was a problem hiding this comment.
All good! I've been extremely busy with both work and non-work for the last six months, so I appreciate others contributing!
yfre
pushed a commit
that referenced
this pull request
Oct 18, 2026
Addresses review feedback on #206.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Stage Release on Master Branch workflow ends in failure even when the release itself succeeds. In the 2.0.9 run (39164630414), these steps all succeeded:
release:prepare: built, tested, taggedhap-2.0.9and bumped master to2.0.10-SNAPSHOTrelease:performdeploy: uploadedhap-2.0.9jar, pom, sources and javadoc to GitHub PackagesThen the run failed with:
maven-release-plugin uses
deploy site-deployas the defaultrelease:performgoals when the pom has a<distributionManagement><site>element. The site-deploy runs insidetarget/checkout, which has no git credentials, somaven-scm-publish-plugincan't push togh-pages. 2.0.8 failed the same way after its artifacts were already published.Change
Pass
-Dgoals=deploysorelease:performonly deploys the artifacts.goalsis the user property ofrelease:performin maven-release-plugin 3.3.1 (checked withmvn help:describe).The site keeps being published by the Java CI with Maven and Deploy workflow on pushes to master, which was fixed in #205.
Verification
This only takes effect on the next release run, which should then finish green.
🤖 Generated with Claude Code