Skip to content

Release workflow: only run deploy in release:perform #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yfre merged 1 commit into from
Oct 18, 2026
Merged

Release workflow: only run deploy in release:perform #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ jobs:
git config --global user.name "github-actions[bot]"
git config --global user.email "41898282+github-actions[bot]@users.noreply.github.com"
- name: Maven release
run: mvn release:prepare release:perform -B -DreleaseVersion=${{ github.event.inputs.releaseVersion }}
# Only deploy; the site is published by the deploy workflow on pushes to master.

@ccutrer ccutrer Oct 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this comment? While Claude can be great, it sometimes is overly verbose, and it doesn't add any value here.

@yfre yfre Oct 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Cody,

long time. decide to remove some dust from some old projects for which i had no time. hopefully with claude i can at least keep them up to date.
thank you for the review.

@yfre yfre Oct 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and i didnt want bother you with minor changes and minor project, so, i have merged them.

@ccutrer ccutrer Oct 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! I've been extremely busy with both work and non-work for the last six months, so I appreciate others contributing!

run: mvn release:prepare release:perform -B -DreleaseVersion=${{ github.event.inputs.releaseVersion }} -Dgoals=deploy
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Loading