Repository navigation
Conversation
) Add DEFAULT_MIN_VALUE/DEFAULT_MAX_VALUE (and DEFAULT_STEP for float characteristics) and a constructor taking min/max (and step) to 19 characteristics that only supported fixed ranges, following the pattern of RotationSpeedCharacteristic. Existing constructors delegate with the previous values, so their serialized output is unchanged.
This was referenced Oct 18, 2026
Member
|
Percentage characteristics and hue have fixed ranges by definition, so only the tilt angles keep the min/max constructors.
yfre
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #162
What
The tilt angle characteristics get
DEFAULT_MIN_VALUE/DEFAULT_MAX_VALUEconstants and a constructor takingminValue, maxValuebefore the existing parameters. The existing constructor delegates with −90/90, the same pattern asColorTemperatureCharacteristic.Covered:
CurrentTiltAngle,TargetTiltAngle(slat), andCurrent/TargetHorizontalTiltAngleandCurrent/TargetVerticalTiltAngle(window covering).Use case: blinds whose slats only tilt part of the −90..90° range, e.g. 0..90°.
Following review, the percentage characteristics and hue were dropped from this PR, since their ranges are fixed by definition.
Compatibility
No breaking changes: existing constructors and their serialized output are unchanged, and only constructors and constants are added.
Testing
mvn -B packageon JDK 11: all tests pass.CustomTiltAngleRangeTestchecks:Still to do before merging: verify in the Home app that the tilt control respects a custom range such as 0..90.