Repository navigation
criteria: add build_quantity_criteria_parser for physical-quantity criteria - #5
Merged
Merged
Conversation
…ria, update tests, and document usage in changelog and module init.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the physical-quantity criteria grammar out of compareExpressions into
lambdafeedback.criteria. First of a stack: #6 and #7 build on it.Changes
build_quantity_criteria_parser(reserved_expressions, token_list=, productions=)in the newquantity_grammar.py, with defaultsQUANTITY_TOKENS/QUANTITY_PRODUCTIONS. It parses:response matches answer, and=,<=,>=,<,>between quantities;dimension(response) matches dimension(answer).generate_criteria_parserin compareExpressions' physical-quantity context, and its parse trees are unchanged (operator labels keep their surrounding spaces, e.g." matches ").build_criteria_parser, so either can fill the same slot.reserved_expressionsisn't used yet: onlyresponseandanswerscan asQUANTITY; other text isINPUT.lambdafeedback.criteria; CHANGELOG entry under Added.Downstream
Additive. compareExpressions can switch its physical-quantity context to this parser.
Verification
INPUT.🤖 Generated with Claude Code