Repository navigation
criteria: add split_criteria, raising CriteriaSyntaxError on unbalanced brackets - #6
Merged
Merged
Conversation
…se `CriteriaSyntaxError` for invalid syntax, and update tests, module init, and changelog.
…ria, raise `CriteriaSyntaxError` for unsupported relations, and update tests, module init, and changelog.
This was referenced Oct 16, 2026
criteria: add `where_substitutions` to read the substitutions of a `where` criterion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #5: merge that first, and this PR's base will then switch to
main.Moves
split_criteriaout of compareExpressions'evaluation.pyintolambdafeedback.criteria.Changes
split_criteria(criteria)in the newsplit.pysplits on the commas outside(),[]and{}, and strips each criterion. Each kind of bracket is counted on its own.CriteriaSyntaxError(aCriteriaErrorandValueError) for a malformed criteria string.CriteriaSyntaxError. The old version silently stopped splitting at the first such bracket.Downstream
compareExpressions can import this in place of its own copy. Criteria with unbalanced brackets will now raise instead of being split partially.
Verification
🤖 Generated with Claude Code