Repository navigation
criteria: add where_substitutions to read the substitutions of a where criterion - #7
Merged
Merged
Conversation
…ria, raise `CriteriaSyntaxError` for unsupported relations, and update tests, module init, and changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #6: merge that first, and this PR's base will then switch to
main.Moves the node-reading half of compareExpressions'
parse_where_substitutionsintolambdafeedback.criteria.Changes
where_substitutions(substitutions)in the newwhere.pytakes the second child of aWHEREnode (oneEQUALITY, or aSEPARATORof them) and returns[(name, expression), ...]with the expressions as text.criteriastill doesn't depend onexpression_parsing.where(where x > 2,where x proportional to y).where_substitution_nodesreturned the node itself for these instead of a list; this raisesCriteriaSyntaxError.SEPARATORthat mixes in such a relation (where a = 2; x > 3) used to be read as substitutions, and also raises now.Downstream
compareExpressions keeps parsing the expression text itself, and should catch
CriteriaSyntaxErrorwhere it previously handled a non-list result.Verification
🤖 Generated with Claude Code