Repository navigation
Conversation
1 of 3 tasks
2 of 3 tasks
Owner
Author
|
Combined into #239. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds the stream error family and maps each of Core's failure kinds to it.
StreamRefusedErroris for a write the store refused, andStreamStorageErroris for a store that failed.StreamOutcomeUnknownErrorsits under the storage error.error_from_failuremaps eachStreamFailurekind to its class. A kind this release doesn't know is a storage error.StreamRecordErrorcarries the cursor of a record a reader can't decode.BEGINNINGandENDare the only cursors lang names. Core mints and checks every other one.Why?
Core reports one kind per failure, so every SDK raises the same error for the same failure (DD-21). A record skipped with a log line is data the reader never hears of.
How did you test it?
Link to a test plan if any -
tests/contrib/streams/test_errors_cursors.py. A new kind in Core fails the mapping test first.