Skip to content

[Brook] Reached Core's stream store with records and errors. - #239

Closed
moetemp wants to merge 16 commits into
mainfrom
moe/brook/v2/p2c-errors-cursors
Closed

moetemp wants to merge 16 commits into
mainfrom
moe/brook/v2/p2c-errors-cursors

Conversation

@moetemp

@moetemp moetemp commented Oct 16, 2026 •

Copy link
Copy Markdown
Owner

What changed?

This PR pins Core to the in-process stream service and reaches it from Python, with records and errors. A small pyo3 module builds a store from a serialized StreamStoreConfig. scripts/gen_bridge_client.py generates a typed StreamService, so no stream call is hand-written. Lang takes the plaintext content_hash and the batch digest before the codec, and error_from_failure maps each of Core's StreamFailure kinds to one error class.

Why?

The store runtime lives in Core now, so every Core-based SDK binds one copy of it (DD-86). Only lang has the plaintext, so hashing before the codec keeps retries deduped (DD-11). One failure kind per failure means every SDK raises the same error (DD-21).

How did you test it?

Link to a test plan if any -

  • Unit Tests
  • Staging
  • End to End Tests

Ran the bridge store tests on the dev server with Core's memory store. The digest test checks against the vector Core's tests pin.

@moetemp

moetemp commented Oct 21, 2026

Copy link
Copy Markdown
Owner Author

Replaced by the Brook v3 stack, #322 to #338.

@moetemp moetemp closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant