Skip to content

[Brook] Added stream topics, references and the store plugins. - #240

Closed
moetemp wants to merge 14 commits into
moe/brook/v2/p2c-errors-cursorsfrom
moe/brook/v2/p2e-provider-plugin
Closed

moetemp wants to merge 14 commits into
moe/brook/v2/p2c-errors-cursorsfrom
moe/brook/v2/p2e-provider-plugin

Conversation

@moetemp

@moetemp moetemp commented Oct 16, 2026 •

Copy link
Copy Markdown
Owner

What changed?

This PR adds typed stream topics, StreamRef and the RedisStreams and MemoryStreams client plugins. A topic name follows the same rule as Core. StreamRef.kind is a plain str, so a ref from a later release still decodes. The store plugin connects in connect_service_client, so the client's handles and every Worker built from it share one store. A store on a Worker alone raises ValueError.

Stacked on #239.

Why?

Core runs the store, so the provider classes become configuration (DD-6). Core checks a stream's owner over the connection that connected the store, so the store comes from the client. A string kind lets later owner kinds land with no type change (DD-2).

How did you test it?

Link to a test plan if any -

  • Unit Tests
  • Staging
  • End to End Tests

Ran the store plugin tests on the dev server.

@moetemp

moetemp commented Oct 21, 2026

Copy link
Copy Markdown
Owner Author

Replaced by the Brook v3 stack, #322 to #338.

@moetemp moetemp closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant