Repository navigation
feat(auth): make AppPasswordCreatedEvent public and dispatch it everywhere - #65736
Draft
karlitschek wants to merge 1 commit into
Draft
karlitschek wants to merge 1 commit into
karlitschek wants to merge 1 commit into
Conversation
This was referenced Oct 20, 2026
| */ | ||
|
|
||
| namespace OC\Authentication\Events; | ||
| namespace OCP\Authentication\Events; |
Member
There was a problem hiding this comment.
globalsiteselector app is listening to that event.
I think we should proactively make it react to both, and still continue with the approach of replacing the event here instead of dispatching both or doing other shenanigans
…where The event moves from OC\Authentication\Events to OCP\Authentication\Events so apps can react to every new app password, for example to remember which session and address created it. It is now also dispatched when an app password is created in the personal security settings and when a login flow v2 is completed. The settings app already publishes the "app password created" activity from its listener for this event, so its controller no longer publishes it directly. Assisted-by: ClaudeCode:claude-opus-5-5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
karlitschek
force-pushed
the
feat/public-app-password-created-event
branch
from
October 25, 2026 19:40
6cd6a8c to
9384100
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One of seven small, independent core changes needed by a planned
intrusion_detectionapp. Each can be reviewed and merged on its own:AppPasswordCreatedEvent, dispatched everywhere ← this PRIProvider::invalidateTokenById()in the public token providerShareLinkAccessFailedEventPasswordResetRequestedEventIChallengeRequester: ask for the second factor again in a sessionIEventDispatchertoLoginFlowV2Service; whichever merges second needs a trivial rebase.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)
AI disclosure: this change was written with Claude Code (claude-opus-5-5) and reviewed by the author; every commit carries an
Assisted-bytrailer.🤖 Generated with Claude Code