Repository navigation
feat(sharing): dispatch an event when a share link access fails - #65738
Draft
karlitschek wants to merge 1 commit into
Draft
karlitschek wants to merge 1 commit into
karlitschek wants to merge 1 commit into
Conversation
This was referenced Oct 20, 2026
nickvergessen
approved these changes
Oct 23, 2026
Add ShareLinkAccessFailedEvent, dispatched when a public share link is opened with a token that does not exist or with a wrong share password, on the share page and over public WebDAV (both public.php/dav and the legacy public.php/webdav). It is dispatched next to the existing brute-force attempt registration, so apps can recognise someone guessing share tokens or share passwords across addresses. Assisted-by: ClaudeCode:claude-opus-5-5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
karlitschek
force-pushed
the
feat/share-link-access-failed-event
branch
from
October 25, 2026 19:40
633b1b2 to
7445ec7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One of seven small, independent core changes needed by a planned
intrusion_detectionapp. Each can be reviewed and merged on its own:AppPasswordCreatedEvent, dispatched everywhereIProvider::invalidateTokenById()in the public token providerShareLinkAccessFailedEvent← this PRPasswordResetRequestedEventIChallengeRequester: ask for the second factor again in a sessionTODO
Checklist
3. to review, feature component)stable32)AI (if applicable)
AI disclosure: this change was written with Claude Code (claude-opus-5-5) and reviewed by the author; every commit carries an
Assisted-bytrailer.🤖 Generated with Claude Code