Repository navigation
Conversation
fix(repository): send the GitLab token only to the GitLab server feat(repository): read tokens from `DLOAD_TOKEN_<HOST>`, ahead of `GITHUB_TOKEN` and `GITLAB_TOKEN` docs: describe self-hosted servers and per-server tokens docs(skill): cover the `server` attribute The token variable is derived from the server address so that only the user's environment, never a config file, decides which host receives a token; `GITHUB_TOKEN` and `GITLAB_TOKEN` stay with the public hosts, and plain http carries a token only to loopback. Closes #143 Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks done
A Mockery URI returns null from getScheme() under psr/http-message 1.1, which broke the lowest-deps jobs once a token makes the client check the host. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
<repository server="...">points a repository at GitHub Enterprise Server, a self-hosted GitLab or a local fake API:[scheme://]host[:port],httpsby default; the API is{server}/api/v3(GitHub) /{server}/api/v4(GitLab). Without it nothing changes.DLOAD_TOKEN_<HOST>(e.g.DLOAD_TOKEN_GHE_EXAMPLE_COM).DLOAD_TOKEN_GITHUB_COM/DLOAD_TOKEN_GITLAB_COMwin overGITHUB_TOKEN/GITLAB_TOKEN, which never leave the public hosts. A token goes only to the exact scheme, host and port of its server, and over plainhttponly to loopback. The GitLab client used to attach its token to every request; it now has the same host check.github@ghe.example.com/owner/repo); paths and records of the public hosts are unchanged, so existing registries stay valid.Repository::getId()gives the downloader that key.Why?
Design agreed in #143 (comment). Unblocks roadrunner-php/cli#49, whose
rr getacceptance tests run against a local fake API.Checklist