feat: use DLoad to download binaries

[roxblnfk]

What was changed

• rr get-binary and rr download-protoc-binary keep their options and output, but the download itself (release lookup, asset selection, download, extraction) is done by DLoad (internal/dload). The overwrite prompt and .rr.yaml generation stay in the CLI. rr versions still uses the built-in GitHub client.
• Requirements: PHP >=8.2, symfony/console / symfony/http-client ^6.4 || ^7 || ^8 (DLoad's minimums).
• Option mapping: --filter + --stability → rr:<filter>@<stability>; --filter='*' → no constraint + --stability; --os, --arch, --location → --os, --arch, --path; a confirmed overwrite → --force. --refresh is always on, so DLoad's version-registry cache never hides a fresh release. The default filter is the RoadRunner v3 one from feat: support RoadRunner v3 #48 (3.* or the installed metapackage major).
• A bundled empty resources/dload.xml is passed as --config; otherwise a project's ./dload.xml with an rr action would silently override --filter.
• RR_GITHUB_API_URL keeps its meaning from feat: read the GitHub API URL from RR_GITHUB_API_URL #65 (the full API URL). https://api.github.com changes nothing; a GitHub Enterprise URL scheme://host[:port]/api/v3 becomes a temporary config that re-declares the rr and protoc-gen-php-grpc entries with <repository server="scheme://host[:port]"> (feat(repository): support self-hosted servers via the server attribute php-internal/dload#148). Any other path is rejected: DLoad always serves a server's API at {server}/api/v3.
• Tokens: GITHUB_TOKEN is honoured for the public GitHub only; DLoad never sends it to another host. A GitHub Enterprise token goes into DLOAD_TOKEN_<HOST> (e.g. DLOAD_TOKEN_GHE_EXAMPLE_COM).

Why?

One downloader for the RoadRunner ecosystem instead of a second copy of release lookup and archive handling in the CLI.

Review notes

• Draft until DLoad 1.19.0. composer.json requires "internal/dload": "dev-feat/repository-server as 1.19.0" — the branch of feat(repository): support self-hosted servers via the server attribute php-internal/dload#148, which adds <repository server>. Switch to ^1.19 once it is released.
• The acceptance tests run against a local fake GitHub Enterprise (php -S, API under /api/v3, one server per scenario since a DLoad server has no path). Two DLoad bugs are skipped there: an exact pre-release filter (-f 3.5.0-beta.1) matches nothing, and with no archive for the platform DLoad picks a .deb it cannot extract instead of an older release.
• DLoad version ordering. DLoad (1.18.0) sorts with version_compare(), so with no constraint it picks 2025.1.15 over 3.0.0 (rr get-binary -f '*' installs 2025.1.15). The default filter is not affected. Needs the same fix in DLoad as in feat: support RoadRunner v3 #48.
• DLoad has no public PHP API: everything, including Internal\DLoad\Command\Get, is @internal. The integration runs the get command in-process (suppressed InternalClass).
• --os=unknown-musl maps to linux; the libc is always auto-detected by DLoad, so forcing a musl build from a glibc host is no longer possible.
• Overriding Command::getRepository() in a GetBinaryCommand subclass no longer changes where the binary comes from; it only affects versions.
• The Archive\* classes and the Repository asset helpers are now unused by the commands but are kept, since removing public classes is a BC break. So Binaries in the archive root are not extracted #59, RepositoriesCollection drops releases of all but the last repository #60, Releases with non-version tags are named d-<tag> instead of dev-<tag> #61 and the .phar part of .phar assets cannot be opened, and a failed config generation still writes .rr.yaml #62 stay open.

Checklist

• Tested
  • Tested manually on Windows: get-binary default, -f '3.*' -s beta → 3.0.0, -f '9.*' → fails with exit 1, existing binary → prompt/skip; download-protoc-binary -f 2025.1 → 2025.1.0
  • Unit tests added
  • Acceptance tests pass locally on Windows with outbound HTTPS blocked, so none reaches api.github.com
• Documentation

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}

[roxblnfk]

@coderabbitai review

[coderabbitai]

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[roxblnfk]

Blocked by php-internal/dload#143: the rr get acceptance tests (#66) point rr at a local fake GitHub through RR_GITHUB_API_URL, and on this branch that address reaches DLoad as <repository host="…">, which DLoad does not support yet. Until it does, the acceptance tests here are expected to fail.