Skip to content

Fx self-check on macOS - #22152

Merged
ilevkivskyi merged 2 commits into
masterfrom
fix-macos-self
Oct 9, 2026
Merged

ilevkivskyi merged 2 commits into
masterfrom
fix-macos-self

Conversation

@ilevkivskyi

Copy link
Copy Markdown
Member

@cdce8p

cdce8p commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

Hmm, I'm still getting the warning on macos.

Would this still resolve the original issue?

    if (
        PSUTIL_AVAILABLE
        and (psutil.LINUX or psutil.WINDOWS or psutil.FREEBSD)
        and sys.platform != "darwin"
    ):

@ilevkivskyi

Copy link
Copy Markdown
Member Author

Oh, this is annoying, my trick only works at top-level. I guess we would need to use the if...

@cdce8p cdce8p left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The self check for macos is working now. Thanks @ilevkivskyi

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

scipy-stubs (https://github.com/scipy/scipy-stubs)
+ tests/misc/test_submodules_empty.pyi:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports

@ilevkivskyi
ilevkivskyi merged commit 47f4844 into master Oct 9, 2026
25 checks passed
@ilevkivskyi
ilevkivskyi deleted the fix-macos-self branch October 9, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants