Skip to content

fix: align local test commands with their supported workflows - #1447

Open
fhammerschmidt wants to merge 2 commits into
masterfrom
fix/1421-local-test-commands
Open

fhammerschmidt wants to merge 2 commits into
masterfrom
fix/1421-local-test-commands

Conversation

@fhammerschmidt

@fhammerschmidt fhammerschmidt commented Oct 11, 2026 •

Copy link
Copy Markdown
Member

The README advertises local screenshot updates even though baselines belong to CI, and full-site Cypress commands default to port 8080 while the development server uses 5173.

Remove the local vitest:update aliases and document dispatching the screenshot workflow against a pushed feature branch, then pulling and reviewing its commit. Keep the internal CI update command and local-update guard. Point full-site Cypress at http://localhost:5173, document starting yarn dev and overriding the URL, and describe the homepage suite's managed production server on port 4173.

Validation:

  • Formatting, strict ReScript compilation, and config import checks pass.
  • A local Vite server returned HTTP 200 for /, /try, and /@vite/client through http://localhost:5173.
  • Verified homepage tests retain port 4173 and local screenshot updates remain blocked. No snapshots changed.

Docs preview

Website master, branch fix/1421-local-test-commands; no compiler changes.

Part of #1421.
Fixes #1415

Remove local screenshot-update aliases and document the feature-branch CI workflow that owns visual baselines. Point the full-site Cypress suite at the Vite dev server, explain server startup and URL overrides, and distinguish the managed production homepage suite.

Fixes #1415
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
guide 63e9254 Commit Preview URL

Branch Preview URL
Oct 11 2026, 10:21 PM

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T21:39:05.697163Z c704e16 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Lighthouse baseline

Compared with target branch master at commit a62233b. Scores are the median of 3 runs against the deployed Cloudflare preview.

Category Target Current Change
Performance 84 84 0
Accessibility 80 80 0
Best practices 100 100 0
SEO 92 58 -34

Download the full Lighthouse reports and baseline

Commit f3b1da5 · Cloudflare preview

Keep localhost as the full-site Cypress hostname while correcting the default port to 5173. Align the README default URL and alternate-port example with the config.
@github-actions

Copy link
Copy Markdown
Contributor

Docs preview

This branch was successfully deployed

2 active deployments
preview — 63e92540 Deployed Oct 11, 2026 by github-actions[bot]
guide-preview — 63e92540 Deployed Oct 11, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

yarn vitest:update (documented) throws locally; local Cypress scripts target an unserved port

1 participant