Skip to content

docs: align contributor guidance with the current monorepo - #1449

Open
fhammerschmidt wants to merge 2 commits into
masterfrom
fix/1421-repo-docs
Open

fhammerschmidt wants to merge 2 commits into
masterfrom
fix/1421-repo-docs

Conversation

@fhammerschmidt

@fhammerschmidt fhammerschmidt commented Oct 11, 2026 •

Copy link
Copy Markdown
Member

Contributor and agent instructions still described the old single-app layout, Prettier tooling, and a removed MDX integration. Align the guidance with the current monorepo and documented commands with the scripts they invoke.

Fixes #1417. Part of #1421.

  • Update AGENTS.md, README, and CONTRIBUTING with repository-root workspace paths, the docs site's runtime SSR for /try, the guide's Worker deployment and separate CSS, the current @mdx-js/mdx compilation/component mapping, and published browser compiler bundles versus the installed example-check compiler.
  • Document Oxfmt, Yarn 4.13.0, staged Lefthook formatting, and the two tracked guide compiler outputs. Keep the raw-JavaScript guidance consistent with the existing requirement to use it only when explicitly requested.
  • Replace the Prettier VS Code recommendation with the official Oxc extension, and ignore bundled Yarn releases by pattern.
  • Describe all three yarn test checks, the working directory for direct script commands, the example checker's glob scope, and the link checker's full-tree scan and CI-only failure status.
  • Distinguish docs-only build and Vitest commands from the guide commands and the combined headless test command. Run Oxfmt and ReScript formatting from the repository root across all four workspaces, with the docs workspace alias delegating to the root.

Branch: fix/1421-repo-docs, based on website master (v12), pushed directly to rescript-lang/rescript-lang.org. No compiler repository changes.

Validation: repository-wide Oxfmt check passes; all 20 relative Markdown links and heading targets resolve; documented Yarn version and JSON configuration agree with the pinned release. The documented targeted example command passes for manual/module-functions.mdx, and the link check from apps/docs passes with CI=1. Eight temporary .res/.resi probes confirm that root formatting repairs sources in all four workspaces, and both formatter checks pass after removing the probes. No application source or screenshots changed. CI is running for the review fixes.

Related work: #1447 updates local test and screenshot workflows; #1448 adds ReScript formatting and generated-output CI checks. Its two formatting-script changes are also included here so these instructions work independently; those script changes are identical in both PRs.

Document the workspace paths, docs SSR and guide deployment, current MDX pipeline, compiler sources, staged formatting hooks, and generated output policy. Clarify link-check working directories and CI behavior, recommend Oxc in VS Code, and ignore bundled Yarn releases by pattern.

Refs #1417 and #1421.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T23:06:29.842924Z 4ea200d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
guide 19daf80 Commit Preview URL

Branch Preview URL
Oct 11 2026, 11:18 PM

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Lighthouse baseline

Compared with target branch master at commit a62233b. Scores are the median of 3 runs against the deployed Cloudflare preview.

Category Target Current Change
Performance 84 86 +2
Accessibility 80 80 0
Best practices 100 100 0
SEO 92 58 -34

Download the full Lighthouse reports and baseline

Commit 605ca2d · Cloudflare preview

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4ea200d921

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread README.md
Comment thread README.md Outdated
Comment thread AGENTS.md Outdated
Document separate docs and guide production builds and Vitest commands. Run Oxfmt and ReScript formatting from the monorepo root, with the docs alias delegating there, so all four workspaces are covered.
@github-actions

Copy link
Copy Markdown
Contributor

Docs preview

This branch was successfully deployed

2 active deployments
preview — 19daf80c Deployed Oct 11, 2026 by github-actions[bot]
guide-preview — 19daf80c Deployed Oct 11, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AGENTS.md / README / CONTRIBUTING describe an older layout and toolchain

1 participant