Repository navigation
ci: check ReScript formatting and committed output - #1448
fhammerschmidt wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
guide | 48b1988 | Commit Preview URL Branch Preview URL |
Oct 11 2026, 10:52 PM |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa47e87128
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Lighthouse baselineCompared with target branch
Download the full Lighthouse reports and baseline Commit |
Remove compiler-generated tracked files identified by their committed header before rebuilding. Preserve handwritten JavaScript and detect output whose source was deleted or whose workspace was excluded from the build.
This branch was successfully deployed
1 participant
Pull requests could pass CI with unformatted ReScript or stale committed compiler output. Check ReScript formatting across all four workspaces and compare tracked JavaScript output after a clean build.
Fixes #1416 together with the unused-value/export gate in #1443. Part of #1421.
yarn ci:formatto run both Oxfmt andrescript format --check. Run the format commands from the monorepo root and delegate the docs workspace aliases to them, so guide sources are included too.yarn ci:generatedto the existing Site_Checks job. It cleans compiler artifacts, removes tracked compiler output identified by the generated-file header in Git's index, runs the strict ReScript build, and fails with a Git diff if tracked.jsxor.mjsoutput changes. Removing the output first also catches deleted or excluded sources; handwritten JavaScript is preserved.routes.jsx, which already differed from fresh compiler output, and document how to run and fix the checks.Branch:
fix/1421-rescript-ci, based on websitemaster(v12), pushed directly torescript-lang/rescript-lang.org. No compiler repository changes. The reanalyze gate stays in #1443; this PR covers the remaining formatting and generated-output checks.Validation: Oxfmt and ReScript checks pass. Temporary formatting errors in both
.resand.resifiles were rejected in all four workspaces, and restored sources pass. The generated-output diff rejected the existing stale guide output; after regeneration, a second clean build passes with no tracked JavaScript differences. Additional real-build probes reject orphaned output after deleting a source/interface pair and after excluding the guide workspace from the build. All temporary source/configuration changes were restored; the final clean build matches all tracked JavaScript, and strict compilation succeeds for all 585 modules. The latest CI run passes both the formatting job and the corrected generated-output step; the remaining jobs are still running.