Repository navigation
feat: read the GitHub API URL from RR_GITHUB_API_URL - #65
Merged
Merged
Conversation
Releases can be fetched from GitHub Enterprise, a mirror or a mock server. The variable is not `GITHUB_API_URL` because GitHub Actions sets that one in every job. Releases are requested 100 per page, so listing them takes 2 requests instead of about 7. Assisted-By: Claude Opus 5.5
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 7 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 tasks done
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
RR_GITHUB_API_URLenvironment variable: base URL of the GitHub REST API used to list RoadRunner releases (defaulthttps://api.github.com). It letsrrwork against GitHub Enterprise, a mirror or a mock server, and is the hook for black-box acceptance tests.GitHubRepositoryaccepts the API URL as an optional fourth constructor/create()argument; existing calls are unchanged.per_page=100, so listing all RoadRunner releases takes 2 requests instead of about 7, which matters under the 60 requests/hour anonymous limit.Why?
The variable is deliberately not
GITHUB_API_URL: GitHub Actions sets that one in every job (and points it at the GHES API there), so reusing it would silently redirectrrin CI.Checklist