Repository navigation
test: add acceptance tests for rr get - #66
Merged
Merged
Conversation
Releases can be fetched from GitHub Enterprise, a mirror or a mock server. The variable is not `GITHUB_API_URL` because GitHub Actions sets that one in every job. Releases are requested 100 per page, so listing them takes 2 requests instead of about 7. Assisted-By: Claude Opus 5.5
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (21)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe CLI can use a configurable GitHub releases API endpoint. The change adds acceptance tests for ChangesGitHub API and
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~45 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The acceptance workflow has no identified blocker and is ready to merge after normal checks. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 17.14% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 70 functions across 16 files. (5 skipped:… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Linked Issues check |  |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Description Check | |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly identifies the main change: adding acceptance tests for the rr get command. It is concise and related to the pull request objectives. |
Full details: Docstring Coverage
Explanation
Docstring coverage is 17.14% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 70 functions across 16 files. (5 skipped: 5 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
- Commit to this branch
- Create a new PR
🛠️ Fix failing CI checks 💡
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
- Commit to this branch
- Create a new PR
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
The tests run `bin/rr` as a separate process against a fake GitHub API served by `php -S`, reached through RR_GITHUB_API_URL, and check the exit code, the installed binary, `.rr.yaml` and the requests made. They run on Linux and Windows in their own workflow and are kept out of Infection, since mutants in a child process are never covered. A live suite against the real GitHub runs only on manual dispatch. Six cases that expose bugs are skipped with the reason: RC tags sort below beta ones, an unknown --os/--arch still fetches the releases, and a kept binary still exits with 0. Assisted-By: Claude Opus 5.5
roxblnfk
force-pushed
the
test/acceptance
branch
from
October 9, 2026 22:24
0e4c78a to
dee4c5f
Compare
This was referenced Oct 9, 2026
Assisted-By: Claude Opus 5.5
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
AcceptanceTesto suite: black-box tests that runbin/rr getas a separate process in a temporary directory with a clean environment, against a fake GitHub API (tests/Acceptance/Server/router.phpunderphp -S) reached throughRR_GITHUB_API_URL.fake rr <version> <os> <arch>marker),.rr.yamland the request log; console text is only matched loosely.--filter,--stability, other OS/arch (rr.exefrom a zip, darwin tar.gz), fallback past a release without the assembly (.deb/protoc assets ignored), unknown versions,--no-config/-p/--preset, existing.rr.yamland binary, interactive answers, 403 rate limit, 404 asset, unreachable API, pagination, request budget,get/get-binary.Acceptance Testsworkflow runs the suite on Ubuntu and Windows (PHP 8.2 and 8.5); thetestoworkflow and Infection run only theUnitsuite.Livesuite downloads real binaries from GitHub; it is registered only withRR_CLI_LIVE_TESTS=1and runs onworkflow_dispatchonly.Review notes
--stability=rcmeansdev(--stability=rc is treated as dev #67); an unknown--os/--archstill fetches the releases (Unknown --os or --arch still fetches the releases before failing #68); a kept existing binary exits with 0 (get-binary exits with 0 when the existing binary is kept #69).SHELL_INTERACTIVE=1; all other runs pass--no-interactionexplicitly.Checklist