Repository navigation
ci: build not test - #815
Open
alejandro-vaz wants to merge 3 commits into
Open
alejandro-vaz wants to merge 3 commits into
alejandro-vaz wants to merge 3 commits into
Conversation
GauravPawar101
left a comment
GauravPawar101
left a comment
Collaborator
There was a problem hiding this comment.
wouldn't this introduce silent creeping of cases like Any code in tests/, benches/, or #[cfg(test)] blocks that uses features introduced after Rust 1.86 will pass CI without error.
Collaborator
Author
|
you can't manufacture a feature on the crate that tests use that the library doesn't require by MSRV in other words: MSRV of tests using only the features of the library can never exceed MSRV of the library, unless you inject something else into it |
Collaborator
Author
|
and users don't really care if tests build on their version, they care that the crate builds |
GauravPawar101
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR changes the
nostdandmsrvjobs on the checks workflow to build instead of tests, as tests are handled separately