Repository navigation
lin: throw if SendDynamicResponse is called without InitDynamic - #449
Open
KonradBreitsprecherBkd wants to merge 2 commits into
Open
KonradBreitsprecherBkd wants to merge 2 commits into
KonradBreitsprecherBkd wants to merge 2 commits into
Conversation
ThrowIfNotDynamic checked the same condition as ThrowIfDynamic, so SendDynamicResponse on a controller that was not initialized with InitDynamic (or not initialized at all) was silently processed. Invert the check and throw SilKit::StateError, as documented in LinControllerExtensions.hpp. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Konrad Breitsprecher <Konrad.Breitsprecher@vector.com>
KonradBreitsprecherBkd
marked this pull request as ready for review
October 21, 2026 12:23
KonradBreitsprecherBkd
added
the
status: ready for review
1 of 6 tasks
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Konrad Breitsprecher <Konrad.Breitsprecher@vector.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThrowIfNotDynamic checked the same condition as ThrowIfDynamic, so SendDynamicResponse on a controller that was not initialized with InitDynamic (or not initialized at all) was silently processed. Invert the check and throw SilKit::StateError, as documented in LinControllerExtensions.hpp.