Skip to content

lin: throw if SendDynamicResponse is called without InitDynamic #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KonradBreitsprecherBkd wants to merge 2 commits into
base: main
Choose a base branch
from
Open

lin: throw if SendDynamicResponse is called without InitDynamic #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3cb6b3
lin: throw if SendDynamicResponse is called without InitDynamic
KonradBreitsprecherBkd Oct 21, 2026
e4c4c4a
tests: describe the intention of the SendDynamicResponse test
KonradBreitsprecherBkd Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions SilKit/source/services/lin/LinController.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,13 +161,13 @@ void LinController::ThrowIfDynamic(const std::string& callingMethodName) const

void LinController::ThrowIfNotDynamic(const std::string& callingMethodName) const
{
if (_useDynamicResponse)
if (!_useDynamicResponse)
{
std::string errorMsg = callingMethodName + " can only be called if the node was initialized using InitDynamic!";
_logger->MakeMessage(Logging::Level::Error, TopicOf(*this))
.SetMessage(errorMsg)
.Dispatch();
throw SilKitError{errorMsg};
throw SilKit::StateError{errorMsg};
}
}

Expand Down Expand Up @@ -372,10 +372,7 @@ void LinController::InitDynamic(const SilKit::Experimental::Services::Lin::LinCo

void LinController::SendDynamicResponse(const LinFrame& frame)
{
if (!_useDynamicResponse)
{
ThrowIfNotDynamic(__FUNCTION__);
}
ThrowIfNotDynamic(__FUNCTION__);

// prepare the response update
LinFrameResponse response{};
Expand Down
12 changes: 12 additions & 0 deletions SilKit/source/services/lin/Test_LinControllerTrivialSim.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,6 +811,18 @@ TEST_F(Test_LinControllerTrivialSim, add_remove_handler)
master.ReceiveMsg(&slave1, transmission);
}

// SendDynamicResponse throws a StateError if the controller was not initialized using InitDynamic, including when it
// was not initialized at all.
TEST_F(Test_LinControllerTrivialSim, send_dynamic_response_throws_if_not_dynamic)
{
const auto frame = MakeFrame(17, LinChecksumModel::Enhanced, 4);

EXPECT_THROW(master.SendDynamicResponse(frame), SilKit::StateError);

master.Init(MakeControllerConfig(LinControllerMode::Master));
EXPECT_THROW(master.SendDynamicResponse(frame), SilKit::StateError);
}

////////////
// Tracing
////////////
Expand Down
4 changes: 3 additions & 1 deletion docs/changelog/versions/latest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# [5.0.9] - UNRELEASED

> This changelog entry is still empty.
## Fixed

- LIN: `SendDynamicResponse` now throws a `SilKit::StateError`, as documented, if the controller was not initialized using `InitDynamic`. Previously, the call was silently processed.
Loading