Repository navigation
docs: add Factory issue implementation recipe - #898
rachaelrenk merged 7 commits into
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This PR was generated with Warp. Comment |
Co-Authored-By: Warp <agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR replaces the issue-implementation scaffold with a full Factory recipe covering GitHub, Linear, and Jira intake, foreman routing, validation expectations, and human merge controls. I reviewed the attached annotated diff, PR description, and spec context; no approved or repository spec context was available for implementation drift checks.
Concerns
- One non-blocking security hardening improvement is worth adding to the reusable automation prompt so copied recipes explicitly treat tracker issue text as untrusted requirements, not policy-overriding instructions.
Verdict
Found: 0 critical, 0 important, 1 suggestions
Approve
Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Warp <agent@warp.dev>
There was a problem hiding this comment.
Review summary
The independent agent completed its review for this commit.
Findings
- src/content/docs/factories/use-cases/issue-implementation.mdx:106 — [SUGGESTION] The instruction to make Jira routes' filters nonoverlapping gives no concrete remedy for an existing project-wide route that also matches implementation-ready issues. Requested change: link to canonical exclusion-filter instructions, provide a source-verified exclusion example for the existing route, or explain how to retain one foreman route for both request types while preserving its other workflows.
Verdict
Approve with nits
Co-Authored-By: Warp <agent@warp.dev>
There was a problem hiding this comment.
Review summary
The independent agent completed its review for this commit.
Findings
- src/content/docs/factories/use-cases/issue-implementation.mdx:106 — [SUGGESTION] Making Jira routes' filters nonoverlapping lacks a concrete remedy for an existing project-wide route that also matches implementation-ready issues. Requested change: link to the canonical matcher/exclusion syntax and explain which existing route to narrow, or explain how to retain one foreman route for both request types while preserving its other workflows.
Verdict
Approve with nits
Co-Authored-By: Warp <agent@warp.dev>
52b0e60
into
factory/factory-use-cases-structure



What this feature does
An initial-intake automation routes approved GitHub, Linear, or Jira issues through an existing factory's foreman for implementation, validation, and independent review. The workflow requests human specification approval when needed and leaves merging to people.
Summary
Replaces the issue-implementation scaffold with a ready-work recipe that routes issues through the foreman, optional specification, implementation, validation, and independent review.
Changes
src/content/docs/factories/use-cases/issue-implementation.mdxContent design plan
Audience and JTBD: A team with an approved backlog that wants agents to implement bounded work and hand back reviewable pull requests.
Problem: Existing integration and agent pages do not show how to turn a tracker readiness signal into a validated code change without bypassing product or merge gates.
Goals:
Purpose and value: The guide connects tracker intake to the default factory roles and gives teams a constrained first implementation workflow.
Content type: Feature documentation (combined) — the reader needs workflow guidance and provider-specific setup.
Skill and template:
draft_feature_doc/.agents/templates/feature-doc.md.High-impact scenarios:
Source files consulted
Checked on 2026-10-21:
warp-factory-examples@84e7c952f1506c4bd2784d96fd40a6f4d6398cad: the foreman coordinates work and communicates results, implementation continues an existing specification PR when supplied, and review returns its report to the foreman. The recipe preserves those shared instructions.warp-server@084e0e425af93139c6e95a78e2981dce55557c31, provider_github.go supportsissue_labeledand matching the applied label.teamsandstatesname aliases.project_keysplus a readiness label, followed by an explicit implementation request.keywords, but the inspected session evaluator checks project and labels without evaluating that field. The recipe therefore does not rely on a keyword filter. Confirm behavior with engineering before extending this recipe or canonical references to promise keyword-only routing.Validation and rollout evidence
v1alpha1, SHA-256655d676dbc436f7b89edfe2c37ef9f383c29b459a22b51c87fcda172a6ccde8e.validate_factory_filesreturnedvalid: truewith no diagnostics for a complete minimal tree containing foreman, implement, review, and all three intake variants. Linearteamsandstatesresolution was deferred; the connected workspace must resolve those names on application. Provider access and other state-dependent checks were not performed.docs@9fe3255523eda5c858f3daefd9a15a970a7ea3beagainstwarp-server@084e0e425af93139c6e95a78e2981dce55557c31. Seven relevant intake, provider, definition-management, and delegation gates were enabled in checked-in production configuration. A separate follow-up-related check did not pass production-availability review. The recipe is explicitly scoped to initial intake and does not promise that a new intake prompt replaces an existing work item's instructions. Private flag names and raw output are not published here.Unverified claims
Documentation risk
Risk: engineering-review-required
Rationale: Adds new public Factory workflow guidance and configuration examples that require product review.
Docs override: none
PR stack
Dependency: #895 is the shared base and targets
main. PRs #896–#901 each independently targetfactory/factory-use-cases-structure; no guide PR depends on another guide PR.Human review focus
Co-Authored-By: Oz oz-agent@warp.dev
Co-Authored-By: Warp agent@warp.dev