Repository navigation
docs: add Factory incident resolution recipe - #899
warp-agent-staging[bot] wants to merge 6 commits into
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This PR was generated with Warp. Comment |
Co-Authored-By: Warp <agent@warp.dev>
Preserve the reviewed incident recipe and its investigation-first summary. Co-Authored-By: Warp <agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Review summary
The independent agent completed its review for this commit.
Findings
- src/content/docs/factories/use-cases/production-incident-resolution.mdx:93 — [SUGGESTION] The instruction to send signed synthetic deliveries provides no runnable sender for the matching and nonmatching payloads, and the linked Sentry authentication reference demonstrates verification rather than sending. Requested resolution: add or directly link a runnable signing-and-POST example that reads the Client Secret from an environment variable without printing it, sends the four fixtures, and preserves the disabled-first filter checks and subsequent enabled-run check.
Verdict
Approve with nits
There was a problem hiding this comment.
Overview
This PR replaces the incident-resolution scaffold with a procedure for signed Sentry webhook intake, read-only triage, validation, and human-gated code fixes. The overall direction matches the stated investigation-first scope, and the security-sensitive prompt and credential boundaries are called out. One changed link sends factory readers to the legacy standalone secrets workflow, so that should be fixed before merge.
Concerns
src/content/docs/factories/use-cases/production-incident-resolution.mdx:39links factory credential setup to/platform/secrets/, whose page tells Warp Factories users to follow/factories/secrets/instead.src/content/docs/factories/use-cases/production-incident-resolution.mdx:2still frames the page as resolving production incidents, while the article now focuses on investigation and keeps production mitigation/deployment separate.
Verdict
Found: 0 critical, 1 important, 1 suggestions
Request changes
Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Warp <agent@warp.dev>



What this feature does
Configure incident investigation in an existing factory. Authenticated production events go to the foreman for read-only diagnosis, and a person decides whether to request a reviewed code fix. Paging, incident command, production changes, deployment, and merging remain under the team's existing controls.
Summary
Replaces the production-incident scaffold with an investigation-first recipe and a signed Sentry issue-webhook example.
Review status: Revisions committed and pushed at
3fba6b5eb5af0912a95fd534c0087e21186b4b3f. Validation below covers the revised article; live-provider checks remain unverified as listed below.Changes
src/content/docs/factories/use-cases/production-incident-resolution.mdxissue/created/data.issuefromevent_alert/triggered/data.event. Does not imply a project filter separates mixed environments.Content design plan
Audience and JTBD: An incident owner or service maintainer who wants agents to gather production evidence and prepare a code fix without granting production mutation authority.
Problem: Webhook and integration references describe configuration primitives but not the decisions and validation needed for an incident workflow.
Goals: Route a signed, scoped production event to an existing factory; investigate using read-only diagnostics; return evidence and uncertainty; require a separate human decision before a code fix.
Purpose and value: Connect webhook configuration, agent roles, and credential controls into a task-oriented recipe without duplicating the full reference documentation.
Content type: Procedural recipe with a configuration summary and a bounded example workflow.
Skill and template:
draft_procedural/.agents/templates/procedural.md; reviewed against repository style and documentation-quality guidance.High-impact scenarios: Covers Sentry issue-created events from a production-only project, investigation reports, filter tests, and human-requested fixes. Excludes paging, incident command, production mutation, deployment, rollback automation, and a universal payload format for every alert provider.
Source files consulted
warpdotdev/warp-serverat084e0e425af93139c6e95a78e2981dce55557c31:router/handlers/external/webhook_signature_schemes.go,router/handlers/external/warp_webhook.go,logic/factory_webhooks.go,logic/ai/ambient_agents/automations/provider_webhook.go,model/types/triggers/pattern.go,logic/factoryfile/resolution/webhook.go, andlogic/factoryfile/projector/webhook.go. Checked signing-secret verification, acceptance versus dispatch, deduplication, dry-run matching, nested payload filters, managed-secret references, and generated UID application.warpdotdev/warp-factory-examplesat84e7c952f1506c4bd2784d96fd40a6f4d6398cad. The default foreman can continue to implementation, so this automation explicitly requests investigation only.Validation and rollout evidence
app.warp.devfactory-files validation endpoint both accept the example tree with no diagnostics. A placeholder webhook UID was replaced with a sample UUID for syntax validation. State-dependent apply checks were not run.webhook.schema.jsonSHA256b108204a53bf55c3b5e9d55ce55ed7761e54d6e59592327a6b740152f5169428;automation.schema.jsonSHA25661c15fe6e32dd9e3f918739499b2f2720488609e510cd7d455a7016fd0427fce. Schema/parser acceptance is not end-to-end delivery evidence.Unverified claims
Documentation risk
Risk: engineering-review-required
Rationale: Documents signed webhook intake, payload filtering, production credential boundaries, and a multi-agent workflow.
Docs override: none
PR stack
Dependency: #895 targets
main. This PR targetsfactory/factory-use-cases-structure; remaining recipe PRs are reviewed independently.Human review focus
Agent review conversation
Co-Authored-By: Oz oz-agent@warp.dev
Co-Authored-By: Warp agent@warp.dev