Repository navigation
fix(analytics): make telemetry opt-in instead of default-on - #482
Open
Firefly0619sec wants to merge 1 commit into
Open
Firefly0619sec wants to merge 1 commit into
Firefly0619sec wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Analytics is currently opt-out:
ConsentManager.initialize()defaults toenabled: true, hasConsented: true, andAnalyticsConsentis never rendered, so PostHog starts on first launch without asking the user.src/lib/analytics/consent.ts:Change
enabled: false, hasConsented: false(all four default sites, including the error fallback anddeleteAllData);<AnalyticsConsent />in the app root so first-run users are actually asked (the component already exists and already callsanalytics.enable()/analytics.disable(), it just was not mounted).AnalyticsService.initialize()only initializes PostHog whenhasConsented && enabled, so with this change PostHog stays off until the user accepts.Notes
opcode-analytics-settingsin localStorage keep their stored choice (no forced reset).