Skip to content

fix(analytics): make telemetry opt-in instead of default-on #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Firefly0619sec wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(analytics): make telemetry opt-in instead of default-on #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import { TabManager } from "@/components/TabManager";
import { TabContent } from "@/components/TabContent";
import { useTabState } from "@/hooks/useTabState";
import { useAppLifecycle, useTrackEvent } from "@/hooks";
import { AnalyticsConsent } from "@/components/AnalyticsConsent";
import { StartupIntro } from "@/components/StartupIntro";

type View =
Expand Down Expand Up @@ -531,6 +532,7 @@ function App() {
<OutputCacheProvider>
<TabProvider>
<AppContent />
<AnalyticsConsent />
<StartupIntro visible={showIntro} />
</TabProvider>
</OutputCacheProvider>
Expand Down
16 changes: 8 additions & 8 deletions src/lib/analytics/consent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ export class ConsentManager {
} else {
// Initialize with default settings
this.settings = {
enabled: true,
hasConsented: true,
enabled: false,
hasConsented: false,
};
}

Expand All @@ -41,15 +41,15 @@ export class ConsentManager {
}

return this.settings || {
enabled: true,
hasConsented: true,
enabled: false,
hasConsented: false,
};
} catch (error) {
console.error('Failed to initialize consent manager:', error);
// Return default settings on error
return {
enabled: true,
hasConsented: true,
enabled: false,
hasConsented: false,
};
}
}
Expand Down Expand Up @@ -82,8 +82,8 @@ export class ConsentManager {

// Reset settings with new anonymous ID
this.settings = {
enabled: true,
hasConsented: true,
enabled: false,
hasConsented: false,
userId: this.generateAnonymousId(),
sessionId: this.generateSessionId(),
};
Expand Down