Repository navigation
refactor: remove obsolete website code and check unused exports - #1443
Open
fhammerschmidt wants to merge 3 commits into
Open
fhammerschmidt wants to merge 3 commits into
fhammerschmidt wants to merge 3 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Remove abandoned scripts, compiler installations, components, and data. Keep live MDX mappings and framework entry points, trim unused interfaces, and enforce the monorepo dead-value check in CI. Fixes rescript-lang#1409
fhammerschmidt
force-pushed
the
fix/1421-dead-code
branch
from
October 11, 2026 22:24
3cd3497 to
a2bdd1f
Compare
Remove 42 redundant implementation annotations and document keeping @LiVe in interfaces when available. Retain 44 annotations, each verified necessary by removing it individually and rerunning the analyzer.
Wait for the client router and a gallery state update before focusing the prerendered Get started link. This prevents a one-shot focus event from racing React hydration while preserving the no-prefetch, focus-prefetch, and blur-cleanup assertions.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obsolete compiler installations, scripts, components, and exports remained after the website and guide migrations. Remove the confirmed dead paths and make unused ReScript values and exports fail CI across all workspaces.
Fixes #1409. Part of #1421.
stdlib-toc.json.jsdom.@liveannotations: 42 in.resiinterfaces and two in standalone.resmodules. Remove duplicate implementation annotations and document annotating each entry point only once. Addyarn check:dead-codeand a CI gate for unused values/exports; underscore bindings are intentional discards, while record-field and argument diagnostics remain advisory.Branch:
fix/1421-dead-code, based on websitemaster(v12). No compiler repository changes.Validation: strict ReScript compilation, dead-code check, a real temporary-unused-export failure probe, five diagnostic-check tests, 56 existing Node script tests, guide production build, and formatting pass. Docs production build and validation of all 188 example pages and relative links also pass. Removing each of the 44 remaining annotations individually produces an unused-value/export finding, confirming that all are necessary with the current analyzer. Strict compilation, formatting, and the dead-code gate pass locally. The homepage CSS prefetch test now waits for the client router and an observable React state update before focusing the prerendered link, preserving its initial absence, focus-prefetch, and blur-cleanup assertions. All six CI jobs pass on the latest commit; HomepageRouteCss passes all nine tests and the homepage suite passes all 40 tests.
Integration: keep this cleanup last among the #1421 PRs. Other API, routing, compiler-settings, and playground changes touch the same code and may supersede parts of this cleanup; rebase and drop those edits as the earlier PRs land. The branch is rebased onto current
master, preserving the guide's shared favicon imports and the removal of its obsolete output directory. No static assets or screenshots were changed.