Skip to content

chore: prune redundant package script aliases - #1451

Open
fhammerschmidt wants to merge 2 commits into
masterfrom
fix/1421-package-scripts
Open

fhammerschmidt wants to merge 2 commits into
masterfrom
fix/1421-package-scripts

Conversation

@fhammerschmidt

@fhammerschmidt fhammerschmidt commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

The package-script audit found redundant root aliases and duplicate workspace commands, while several scripts without automated callers are useful contributor tools. Remove eight redundant entries while keeping useful manual contributor commands.

Fixes #1419. Part of #1421.

  • Remove root aliases for build:generate-llms, ci:homepage-performance, ci:test:e2e, dev:vite, dev:wrangler, and prepare. The docs workspace helpers stay available to builds, CI, and direct workspace invocation.
  • Remove docs ci:format and clean:res; use the root commands for these repository-wide operations.
  • Keep the useful manual tools: Cypress, guide/visual watch mode, and the configured image converter. Yarn 4 does not automatically run prepare; docs development calls its workspace script explicitly. Lefthook has its own postinstall for hook installation. See Yarn lifecycle scripts and Lefthook installation.

Branch: fix/1421-package-scripts, based on website master (v12), pushed directly to rescript-lang/rescript-lang.org. No compiler changes or dependency changes.

Validation: Oxfmt and ReScript formatting checks pass. A one-off audit verifies all 24 remaining workspace aliases, local script dependencies, GitHub workflow references, the homepage E2E helper, contributor commands, and explicit development preparation. Local Yarn fails to load the global .yarnrc.yml, including after an unrestricted retry. All six PR CI jobs passed on the script cleanup, verifying installation, builds, script tests, browser and visual tests, and all 40 homepage Cypress tests. Both deployments and Lighthouse also passed. The follow-up only restores the existing scripts README; its formatting check passes.

Coordination: keep Cypress entry points documented by #1447, the root clean:res used by #1448, guide watch mode documented by #1449, and dead-code commands corrected by #1443. This cleanup is incorporated into #1443, #1448, and #1449; merge #1451 first so its changes drop out of their diffs. Merge simulations with #1443, #1447, #1448, #1449, and #1450 pass, and the original CI formatting/generated-output and dead-code commands are preserved.

Keep focused docs helpers in their workspace and retain contributor commands with an explicit purpose. Document manual tools and Yarn preparation behavior, and remove duplicate docs formatting and cleaning entries.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T08:37:13.802227Z 398ef95 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
guide 9f9ad34 Commit Preview URL

Branch Preview URL
Oct 12 2026, 08:45 AM

fhammerschmidt added a commit that referenced this pull request Oct 12, 2026
Include #1451 so its package-script audit can merge first without conflicts. Preserve the root ReScript formatting and generated-output checks and the docs formatting delegate.
fhammerschmidt added a commit that referenced this pull request Oct 12, 2026
Include #1451 so its package-script audit can merge first without conflicts. Preserve the repository-wide root formatter and docs workspace formatting delegate.
fhammerschmidt added a commit to fhammerschmidt/rescript-lang.org that referenced this pull request Oct 12, 2026
Include rescript-lang#1451 so its package-script audit can merge first without conflicts. Preserve the dead-code check and corrected repository-wide reanalyze commands.
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Lighthouse baseline

Compared with target branch master at commit a62233b. Scores are the median of 3 runs against the deployed Cloudflare preview.

Category Target Current Change
Performance 84 84 0
Accessibility 80 80 0
Best practices 100 100 0
SEO 92 58 -34

Download the full Lighthouse reports and baseline

Commit 8f014fb · Cloudflare preview

Keep the package-script audit focused on the eight redundant entries. Explain retained manual commands in the PR description without duplicating package scripts and contributor documentation.
@github-actions

Copy link
Copy Markdown
Contributor

Docs preview

This branch was successfully deployed

2 active deployments
preview — 9f9ad342 Deployed Oct 12, 2026 by github-actions[bot]
guide-preview — 9f9ad342 Deployed Oct 12, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

23 package scripts are run by nothing

1 participant