Repository navigation
Conversation
The pydantic converter wrote a StreamRef in a model with snake case keys, so the harness needed its own aliased model. A pydantic core schema on StreamRef dumps the proto JSON names and loads both forms, with pydantic imported only when a model uses the ref.
This was referenced Oct 21, 2026
Owner
Author
|
Closing as stale. This layer is folded into the v5 tip, #365, and the upstream review uses a fresh series instead. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR gives
StreamRefa pydantic core schema (__get_pydantic_core_schema__). A pydantic model that holds aStreamRefnow dumpsid,workflowIdandfirstExecutionRunId, the proto JSON names, as the payload converter already does. It loads both the proto names and snake case. Pydantic is imported only when a model uses the ref, so it stays optional.Why?
The harness keeps a
StreamRefinside a pydantic model, and pydantic wrote it with snake case keys. So the harness had to add its own aliased model.How did you test it?
pytest tests/contrib/streams/test_pydantic.py. The tests cover:pydantic_data_converterpayload;pydantic_data_converterand a model that carries the ref.Full
poe lintand the full suite pass at this layer, excepttest_envconfig, which reads a config file on this host.